Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFT Block Puller: a common block verifier #4408

Closed
wants to merge 2 commits into from

Conversation

tock-ibm
Copy link
Contributor

@tock-ibm tock-ibm commented Aug 29, 2023

Type of change

  • New feature

Description

BFT Block Puller: a common block verifier to the peer the orderer.

The new implementation verifies the integrity and signatures of a block stream, while keeping a copy of the latest configuration.

Every time a config block arrives, it must first be verified using VerifyBlock and then used as an argument to the UpdateConfig method.

The block stream could be composed of either:

  • full blocks, which are verified using the VerifyBlock method, or
  • block attestations (a header+metadata, with nil data) which are verified using the VerifyBlockAttestation method.

In both cases, config blocks must arrive in full.

This commit also moved BlockVerifierAssembler form orderer/common/cluster/util.go to common/deliverclient/verifier_assembler.go, as it is now used by both orderer and peer. In addition, VerificationRegistry was removed from orderer/common/cluster/util.go as it is no longer in use.

Related issues

#4346

@tock-ibm tock-ibm requested a review from a team as a code owner August 29, 2023 13:19
@tock-ibm tock-ibm marked this pull request as draft August 29, 2023 13:27
@tock-ibm tock-ibm force-pushed the bft-bp-block-verifier branch 3 times, most recently from 465287f to 8e68eab Compare November 20, 2023 17:01
@tock-ibm tock-ibm force-pushed the bft-bp-block-verifier branch 3 times, most recently from 974d7a6 to 46ddfc7 Compare November 30, 2023 11:30
@tock-ibm tock-ibm marked this pull request as ready for review November 30, 2023 11:31
tock-ibm and others added 2 commits November 30, 2023 17:04
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Change-Id: I71aa3fd6f0ea0e4ea529614830ea95dfedb3cd36
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Change-Id: I073a6086cbdb7cfa316b4a638cbb302b57e9d262
@tock-ibm
Copy link
Contributor Author

merged

@tock-ibm tock-ibm closed this Dec 12, 2023
@tock-ibm tock-ibm deleted the bft-bp-block-verifier branch December 12, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants